Fix time based average stats #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pgbouncer makes it look easy: https://github.com/pgbouncer/pgbouncer/blob/master/src/stats.c#L67 :) |
magec
reviewed
May 18, 2023
| pub avg_xact_time: Arc<AtomicU64>, | ||
| pub avg_xact_count: Arc<AtomicU64>, | ||
| pub avg_wait_time: Arc<AtomicU64>, | ||
| total: AddressStatFields, |
magec
reviewed
May 18, 2023
@magec Still wanted to get your eyes on this one and wanted to make sure you update and validate on your end. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stat averages were being calculated incorrectly for example, average query time (latency) was being calculated by dividing the total query time by our stat period (15 seconds). Instead we should be dividing by the number of queries we observed in that stat period.
Also, I've removed the tracking of old stat total, to just tracking the current totals for the given stat period, and after that stat period completes the current totals are re-zeroed (similar to how pgbouncer does it)