Make queue strategy configurable and default to Fifo #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainkabani
changed the title
zainkabani
changed the title
levkk
reviewed
Jun 9, 2023
| @@ -352,7 +355,7 @@ impl General { | |||
| } | |||
|
|
|||
| pub fn default_idle_timeout() -> u64 { | |||
| 60000 // 1 minute | |||
| 600000 // 10 minutes | |||
There was a problem hiding this comment.
Let's not change defaults unnecessarily. People are getting used to them, and it's much easier to change the config when a change is needed.
There was a problem hiding this comment.
That's a valid point.
I'm mainly changing this to match the pgbouncer default, but if we want to keep it as 1 minute then I can revert
levkk
reviewed
Jun 9, 2023
| @@ -390,6 +393,10 @@ impl General { | |||
| pub fn default_prometheus_exporter_port() -> i16 { | |||
| 9930 | |||
| } | |||
|
|
|||
| pub fn default_server_round_robin() -> bool { | |||
There was a problem hiding this comment.
This brings us back to original PgCat behavior before the bb8 queuing strategy change, is that correct?
There was a problem hiding this comment.
That's correct, using a queue instead of stack as the default. Once we figure out if this is causing connection thrashing we can switch the default and match pgbouncer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed some connection thrashing issues with using PgCat and Lifo, defaulting to using Fifo (default of bb8) and making the option configurable
The idle timeout was incorrectly commented as 10 minutes before but actually set to 1 minute. A previous PR of mine fixed the comment but it seems that a value of 10 minutes is a better default for this timeout (same as pgbouncer)