-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle and track startup parameters #478
Merged
levkk
merged 22 commits into
postgresml:main
from
zainkabani:zain/handle-statup-parameters
Aug 10, 2023
Merged
Handle and track startup parameters #478
levkk
merged 22 commits into
postgresml:main
from
zainkabani:zain/handle-statup-parameters
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Jun 18, 2023
levkk
reviewed
Jun 18, 2023
levkk
reviewed
Jun 18, 2023
levkk
reviewed
Jun 18, 2023
levkk
reviewed
Jun 18, 2023
levkk
reviewed
Jun 18, 2023
levkk
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to track startup and other other parameter status packets during the lifetime of client and server connections.
The set of tracked parameters is from pgbouncer. When a client checks out a server connection, it compares the server_parameters that are stored on the client (desired) and on the server. If there's a difference it will send set statements to synchronize the parameters.