Implement Close for prepared statements #482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Add support for
Close (F)
. In transaction mode, the prepared statement will be removed from the client cache, but not from the server cache. In session mode, the prepared statement will be removed from both server and client caches and from the Postgres server itself.Add prepared statement cache size limit, with a cleanup job that removes statements that are above cache size. Cost of removal is amortized across clients, not ran as a maintenance loop out of connection lifetime. We need to write our own internal pool implementation to add the ability to run maintenance on connections out of usage scope. I think the impact at the moment will be mostly negligible because cache eviction should only be active on very active systems that are constantly used, so running a cleanup job out of client usage scope will still block the connection when it's needed.
Bugs
Fixed what may have been a big latency bottleneck caused by incorrect
arc_swap
usage to fetch the idle in transaction config value.