Fixes try_execute_command message parsing bug #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeagher
reviewed
Aug 24, 2023
levkk
reviewed
Aug 24, 2023
| @@ -1291,6 +1295,11 @@ mod test { | |||
| // Shard should start out unset | |||
| assert_eq!(qr.active_shard, None); | |||
|
|
|||
| // Don't panic when short query eg. ; is sent | |||
| let q0 = simple_query(";"); | |||
There was a problem hiding this comment.
Nice! Happy to see test coverage here.
|
Really nice, thank you. |
dat2
reviewed
Aug 24, 2023
| @@ -150,9 +151,13 @@ impl QueryRouter { | |||
| || self.pool_settings.sharding_key_regex.is_some() | |||
| { | |||
| // Check only the first block of bytes configured by the pool settings | |||
| let len = message_cursor.get_i32() as usize; | |||
| let seg = cmp::min(len - 5, self.pool_settings.regex_search_limit); | |||
There was a problem hiding this comment.
it's used in the seg calculation. It needs to be read off the cursor to progress the index that it's pointing to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were double reading the length of the message, this was masked when we had longer queries where we could read those extra bytes without causing an issue. A ruby health check change uncovered that when sending something like
;as a query we were running into panics because the buffer did not have the expected number of bytes.