Added clippy to CI and fixed all clippy warnings
#613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levkk This PR is ready for review. I had to go through several hoops to figure out one change (suggested by |
levkk
reviewed
Oct 10, 2023
| @@ -777,8 +770,8 @@ impl<'de> serde::Deserialize<'de> for DefaultShard { | |||
| D: Deserializer<'de>, | |||
| { | |||
| let s = String::deserialize(deserializer)?; | |||
| if s.starts_with("shard_") { | |||
| let shard = s[6..].parse::<usize>().map_err(serde::de::Error::custom)?; | |||
| if let Some(s) = s.strip_prefix("shard_") { | |||
There was a problem hiding this comment.
Way better. I wonder how clippy figured this out, pretty impressive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a good practice to follow the Rust idioms, and using
clippyand make sure to have no unintentionalclippywarning is a healthy check forpgcat. This PR addsclippyto CI and also fixes all the existingclippywarnings.