Rewrite bash tests to python #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstyushin
approved these changes
Oct 1, 2025
| @@ -0,0 +1,5 @@ | |||
| pytest==8.3.5 | |||
| docker==7.1.0 | |||
| zabbix==1.3.1 | |||
There was a problem hiding this comment.
почему-то данная версия не ищется:
ERROR: Could not find a version that satisfies the requirement zabbix==1.3.1 (from versions: 1.2.0, 1.2.4, 2.0.2)
| @@ -0,0 +1,8 @@ | |||
| from enum import StrEnum | |||
There was a problem hiding this comment.
класс StrEnum доступен начиная с python3.11, соответственно, необходимо отразить в README, что для запуска тестов необходим python3.11+ и не забыть это в дальнейшем учесть при добавлении запуска данных тестов в github-actions.
|
|
||
| subprocess.run( | ||
| [ | ||
| "docker-compose", |
There was a problem hiding this comment.
насколько мне известно, оригинальный docker-compose перешёл в статус deprecated 5 лет назад и в настоящий момент в качестве замены используется вызов плагина docker-compose-plugin как docker compose (без тире).
тут два варианта:
- в рантайме github-actions добавлять алиас
alias docker-compose="docker compose" - заменить вызов на актуальный без дефиса
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В кач-ве первой итерации тесты Баш были переписаны на Python без написания дополнительных проверок.
Поддерживается параметризация версии Postgres, в следующей итерации так же будет добавлена поддержка параметризации типа и версии ОС