Skip to content

[PBCKP-165] get_control_value() int64 buffer vulnerability fix #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2022
Merged

[PBCKP-165] get_control_value() int64 buffer vulnerability fix #496

merged 6 commits into from
Jun 22, 2022

Conversation

avaness
Copy link
Contributor

@avaness avaness commented Jun 15, 2022

please review and commit

@avaness avaness requested a review from funny-falcon June 15, 2022 22:14
funny-falcon
funny-falcon requested changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@funny-falcon funny-falcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. сделай отступы табом, пожалуйста.
  2. сделай в if первым кейсом elog(ERROR). И, учитывая, что он заканчивает выполнение, можно строчки модификации buf_int64_ptr не трогать.

@avaness avaness requested a review from funny-falcon June 16, 2022 17:07
funny-falcon
funny-falcon reviewed Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@funny-falcon funny-falcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется, стало хорошо ))

@funny-falcon funny-falcon merged commit 7e16642 into master Jun 22, 2022
@funny-falcon funny-falcon deleted the PBCKP-165 branch July 4, 2022 07:39
@kulaginm kulaginm added this to the 2.5.7 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funny-falcon funny-falcon funny-falcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
3 participants
@avaness @funny-falcon @kulaginm