Skip to content

Check collector has started in pg_wait_sampling_reset_profile. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
+12 −0
Merged

Check collector has started in pg_wait_sampling_reset_profile. #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pg_wait_sampling.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,10 @@ receive_array(SHMRequest request, Size item_size, Size *count)
pgws_collector_hdr->request = request;
LockRelease(&collectorTag, ExclusiveLock, false);

/*
* Check that the collector was started to avoid NULL
* pointer dereference.
*/
if (!pgws_collector_hdr->latch)
ereport(ERROR, (errcode(ERRCODE_INTERNAL_ERROR),
errmsg("pg_wait_sampling collector wasn't started")));
Expand Down Expand Up @@ -819,6 +823,14 @@ pg_wait_sampling_reset_profile(PG_FUNCTION_ARGS)
pgws_collector_hdr->request = PROFILE_RESET;
LockRelease(&collectorTag, ExclusiveLock, false);

/*
* Check that the collector was started to avoid NULL
* pointer dereference.
*/
if (!pgws_collector_hdr->latch)
ereport(ERROR, (errcode(ERRCODE_INTERNAL_ERROR),
errmsg("pg_wait_sampling collector wasn't started")));

SetLatch(pgws_collector_hdr->latch);

LockRelease(&queueTag, ExclusiveLock, false);
Expand Down