Skip to content

pg_sphere_version() reports version that is different from extension version. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andy-slac opened this issue Mar 1, 2023 · 2 comments
Assignees

Comments

@andy-slac
Copy link

andy-slac commented Mar 1, 2023

With just installed pg_shere from current master, and we observe difference in reported version numbers between pg_sphere_version() and extension version:

=> select pg_sphere_version();
 pg_sphere_version
-------------------
 1.1.5

=> SELECT extversion from pg_catalog.pg_extension where extname = 'pg_sphere';
 extversion
------------
 1.2.0

Aren't they supposed to be the same?

@vitcpp
Copy link
Contributor

vitcpp commented Jun 27, 2023

PR #23 is prepared. The idea is to propagate PGSPHERE_VERSION from Makefile into the code. It allows to have the single place where pg sphere version is set. One more place is the .control file where default_version should be changed as well. There is an idea to add some rule into Makefile to replace default_version with the latest one. Another way is to keep it unchanged. The version mismatch probably will fail the tests if to forget to change the version in .control file (some testing is needed).

@esabol
Copy link
Contributor

esabol commented Jul 4, 2023

PR #23 was merged, so I think this issue can be closed.

@vitcpp vitcpp closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants