fix: serialized responses containing a self join is missing attributes (#675)

Author: zacharygolba

src/packages/router/route/params/utils/get-default-collection-params.js

@@ -1,39 +1,21 @@
 // @flow
 import type Controller from '../../../../controller';
 
+import getDefaultMemberParams from './get-default-member-params';
+
 /**
  * @private
  */
-export default function getDefaultCollectionParams({
-  model,
-  defaultPerPage,
-  serializer: {
-    hasOne,
-    hasMany,
-    attributes
-  }
-}: Controller): Object {
+function getDefaultCollectionParams(controller: Controller): Object {
   return {
-    sort: 'createdAt',
+    ...getDefaultMemberParams(controller),
     filter: {},
-    fields: {
-      [model.resourceName]: attributes,
-      ...[...hasOne, ...hasMany].reduce((include, key) => {
-        const opts = model.relationshipFor(key);
-
-        if (!opts) {
-          return include;
-        }
-
-        return {
-          ...include,
-          [opts.model.resourceName]: [opts.model.primaryKey]
-        };
-      }, {})
-    },
+    sort: 'createdAt',
     page: {
-      size: defaultPerPage,
+      size: controller.defaultPerPage,
       number: 1
     }
   };
 }
+
+export default getDefaultCollectionParams;

src/packages/router/route/params/utils/get-default-member-params.js

@@ -18,7 +18,7 @@ export default function getDefaultMemberParams({
       ...[...hasOne, ...hasMany].reduce((include, key) => {
         const opts = model.relationshipFor(key);
 
-        if (!opts) {
+        if (!opts || model === opts.model) {
           return include;
         }