Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialized responses containing a self-join is missing attributes #675

Merged
merged 4 commits into from
Feb 15, 2017

Conversation

zacharygolba
Copy link
Contributor

This PR fixes a bug where attributes of a model are not included in serialized responses if the model has a self-join in the form of a n:m relationship. Closes #607.

See the follower/followee relationship in the social network example.

@zacharygolba zacharygolba changed the title fix: serialized responses containing a self join is missing attributes fix: serialized responses containing a self-join is missing attributes Feb 3, 2017
@codecov-io
Copy link

codecov-io commented Feb 3, 2017

Codecov Report

Merging #675 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage    92.3%   92.38%   +0.08%     
==========================================
  Files         180      180              
  Lines        2000     1996       -4     
==========================================
- Hits         1846     1844       -2     
+ Misses        154      152       -2
Impacted Files Coverage Δ
...oute/params/utils/get-default-collection-params.js 100% <ø> (+20%)
...er/route/params/utils/get-default-member-params.js 100% <100%> (+20%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e223df...4e829c3. Read the comment docs.

@zacharygolba zacharygolba merged commit 7858af5 into master Feb 15, 2017
@zacharygolba zacharygolba deleted the fix-self-join-response branch February 18, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

belongsTo response missing
2 participants