fix: query parameters are not added to custom routes (#528)

* Add whitelisted query parameters to custom routes

* Add test for query parameters on custom model-less routes

* Remove unused parameters

src/packages/router/route/params/index.js

@@ -9,7 +9,8 @@ import getDefaultCollectionParams from './utils/get-default-collection-params';
 import type { Params$opts } from './interfaces';
 import {
   getMemberQueryParams,
-  getCollectionQueryParams
+  getCollectionQueryParams,
+  getCustomParams
 } from './utils/get-query-params';
 
 /**
@@ -47,6 +48,11 @@ export function paramsFor({
         getDataParams(controller, false)
       ];
     }
+  } else if (type === 'custom') {
+    params = [
+      ...params,
+      ...getCustomParams(controller)
+    ];
   }
 
   return new ParameterGroup(params, {

src/packages/router/route/params/test/params.test.js

@@ -2,14 +2,43 @@
 import { expect } from 'chai';
 import { it, describe, before } from 'mocha';
 
-import { defaultParamsFor } from '../index';
+import { paramsFor, defaultParamsFor } from '../index';
 
 import setType from '../../../../../utils/set-type';
 import { getTestApp } from '../../../../../../test/utils/get-test-app';
 
 import type Controller from '../../../../controller';
 
 describe('module "router/route/params"', () => {
+  describe('#paramsFor()', () => {
+    let getController;
+
+    before(async () => {
+      const { controllers } = await getTestApp();
+
+      getController = (name: string): Controller => setType(() => {
+        return controllers.get(name);
+      });
+    });
+
+    describe('with model-less controller', () => {
+      let params;
+
+      before(() => {
+        params = paramsFor({
+          type: 'custom',
+          method: 'GET',
+          controller: getController('custom'),
+          dynamicSegments: []
+        });
+      });
+
+      it('contains query', () => {
+        expect(params.has('userId')).to.be.true;
+      });
+    });
+  });
+
   describe('#defaultParamsFor()', () => {
     let getController;
 

src/packages/router/route/params/utils/get-query-params.js

@@ -118,7 +118,7 @@ function getIncludeParam({
 /**
  * @private
  */
-function getCustomParams({
+export function getCustomParams({
   query
 }: Controller): Array<[string, ParameterLike]> {
   return query.map(param => [param, new Parameter({

test/test-app/app/controllers/custom.js

@@ -0,0 +1,13 @@
+import { Controller } from 'LUX_LOCAL';
+
+class CustomController extends Controller {
+  query = [
+    'userId'
+  ];
+
+  index() {
+    return 204;
+  };
+}
+
+export default CustomController;

test/test-app/app/routes.js

@@ -13,6 +13,12 @@ export default function routes() {
     only: ['index']
   });
 
+  this.resource('custom', {
+    only: []
+  }, function(){
+    this.get('/', 'index');
+  });
+
   this.resource('images');
 
   this.resource('notifications', {