Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hasMany relationships are not eager loading properly #116

Merged
merged 1 commit into from
May 21, 2016

Conversation

zacharygolba
Copy link
Contributor

Before:

    SELECT posts.id AS post.id, comments.id AS comments.id
      FROM posts
INNER JOIN comments ON comments.post_id = posts.id

After:

SELECT comments.id AS comments.id, comments.post_id AS posts.id
  FROM comments
 WHERE comments.post_id
    IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25)

@zacharygolba zacharygolba merged commit 0f64cc8 into master May 21, 2016
@zacharygolba zacharygolba deleted the has-many-eager-loading branch May 21, 2016 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant