New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource IDs must be strings #211

Merged

zacharygolba merged 3 commits into postlight:master from kureuil:string-id

Jul 10, 2016

Contributor

kureuil commented Jul 10, 2016

According to the spec (http://jsonapi.org/format/#document-resource-object-identification), the value of the resource object identifiers id field should be a string.

kureuil added 3 commits

July 8, 2016 07:13


          errors is a top level member

d1fd037


          Resource ID must be a string

58364d6


          Merge branch 'master' of https://github.com/postlight/lux into string-id

dcd81d7

zacharygolba merged commit a8460e5 into postlight:master

Contributor

zacharygolba commented Jul 10, 2016

This is 👍 . These spec compliance PRs are extremely helpful. Thank you!

zacharygolba added bug squash-and-merge labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug squash-and-merge