Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Added generator for utils #262

Merged
merged 7 commits into from
Aug 4, 2016
Merged

Feat: Added generator for utils #262

merged 7 commits into from
Aug 4, 2016

Conversation

adampash
Copy link
Contributor

@adampash adampash commented Aug 3, 2016

Addresses #255

@zacharygolba
Copy link
Contributor

👍 works great!

One thing though (my fault). I forgot to put the ability to run lux d util and lux d middleware in the issue descriptions for #254 and #255. Can you add that to this PR before merging?

@zacharygolba zacharygolba mentioned this pull request Aug 3, 2016
Merged
@adampash
Copy link
Contributor Author

adampash commented Aug 3, 2016

All right added the delete for utilities, too. I'm afraid that because I'd started updating the middleware branch in preparation for merging, it unfortunately ended up cascading commits... but it's hopefully not a big problem.

@zacharygolba
Copy link
Contributor

That should be fine. Reviewing now...

@zacharygolba
Copy link
Contributor

👍 Works great!

@adampash adampash merged commit d0f4f2b into master Aug 4, 2016
@adampash adampash deleted the feat-add-utility-generator branch August 4, 2016 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
squash-and-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adampash @zacharygolba