Feat: Added CORS to config #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| } | ||
| }, | ||
|
|
There was a problem hiding this comment.
I thought it might be useful to show the CORS config in an example project, so I've left this in here for now.
| @@ -103,7 +104,8 @@ export default async function initialize<T: Application>(app: T, { | |||
|
|
|||
| const server = new Server({ | |||
There was a problem hiding this comment.
I think it would be beneficial to spread the serverOpts here:
const server = new Server({
...serverOpts,
router,
logger
});
|
👏 Awesome work! I have a few suggestions regarding style and structure but functionally speaking this on point! |
|
|
||
| import type { Writable } from 'stream'; | ||
| import type { IncomingMessage, Server as HTTPServer } from 'http'; | ||
|
|
||
| import type { Request } from './request/interfaces'; | ||
| import type { Response } from './response/interfaces'; | ||
| import type { Server$opts } from './interfaces'; | ||
| import type { Server$config } from './interfaces'; |
There was a problem hiding this comment.
We can condense this import down to a single line:
import type { Server$opts, Server$config } from './interfaces';
|
Almost there! |
|
This LGTM. Awesome work! 😃 |
|
P.S: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to configure CORS headers via the config. There's a lot of new-to-me work on this one in terms of Flow, so I'm including some notes.
Closes #282