fix: listening message dispatched before workers are ready #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharygolba
added a commit
that referenced
this pull request
Apr 20, 2016
chore: add ci config and test fixtures fix: hard-coded environment property in Base unit test fix: tests timeout on ci server fix: wrong build task for tests in gulpfile fix: add stdout and stderr listeners to debug test on ci server fix: shebang line not finding node on linux (#32) chore: bump lux up to the latest release in the test-app fix: increase sleep interval before running tests fix: increase sleep interval again fix: decrease sleep interval and stop testing node 4.x for now fix: listening message dispatched before workers are ready (#34) chore: Link to Medium Article in Readme (#33) feat: add pagination to controller integration test fix: sql dump syntax error fix: wrong sql dump :P feat: test against node 4 as well as 5 fix: increase mocha timeout time Node 4 works locally just takes longer to boot. feat: more integration testing fix: logger date incorrect (#35) Merge pull request #36 from postlight/database-missing-port fix: missing port in database config generation chore: bump version to 0.0.1-beta.3 (#37)
zacharygolba
added a commit
that referenced
this pull request
Apr 20, 2016
chore: add ci config and test fixtures fix: hard-coded environment property in Base unit test fix: tests timeout on ci server fix: wrong build task for tests in gulpfile fix: add stdout and stderr listeners to debug test on ci server fix: shebang line not finding node on linux (#32) chore: bump lux up to the latest release in the test-app fix: increase sleep interval before running tests fix: increase sleep interval again fix: decrease sleep interval and stop testing node 4.x for now fix: listening message dispatched before workers are ready (#34) chore: Link to Medium Article in Readme (#33) feat: add pagination to controller integration test fix: sql dump syntax error fix: wrong sql dump :P feat: test against node 4 as well as 5 fix: increase mocha timeout time Node 4 works locally just takes longer to boot. feat: more integration testing fix: logger date incorrect (#35) Merge pull request #36 from postlight/database-missing-port fix: missing port in database config generation chore: bump version to 0.0.1-beta.3 (#37) chore: add travis badge to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
Lux Server listening on {port}message is written to stdout before all worker processes are ready.Before:
After: