Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for relationships module in database package #407

Merged
merged 6 commits into from
Sep 21, 2016
Merged

test: add unit tests for relationships module in database package #407

merged 6 commits into from
Sep 21, 2016

Conversation

zacharygolba
Copy link
Contributor

Closes #400

@codecov-io
Copy link

codecov-io commented Sep 20, 2016 •
edited
Loading

Current coverage is 78.54% (diff: 100%)

No coverage report found for master at ade16b5.

Powered by Codecov. Last update ade16b5...7938765

javamonn
javamonn approved these changes Sep 21, 2016
View reviewed changes
Copy link

@javamonn javamonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a tiny typo (feel free to ignore), this looks good to go 👍

src/packages/database/test/relationship.test.js

const setup = async () => {
subject = await Post.create({
title: '#get() test'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo: title: '#set() test'

@zacharygolba zacharygolba merged commit 233d4a7 into master Sep 21, 2016
@zacharygolba zacharygolba deleted the test-relationships branch September 21, 2016 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javamonn javamonn javamonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharygolba @codecov-io @javamonn