Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing value null in post to type number throws type error #516

Merged
merged 3 commits into from
Nov 12, 2016

Conversation

zacharygolba
Copy link
Contributor

Closes #509

cc @nickschot

@codecov-io
Copy link

codecov-io commented Nov 11, 2016

Current coverage is 88.90% (diff: 97.22%)

Merging #516 into master will increase coverage by 0.19%

@@             master       #516   diff @@
==========================================
  Files           170        170          
  Lines          1841       1847     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1633       1642     +9   
+ Misses          208        205     -3   
  Partials          0          0          

Powered by Codecov. Last update 6cd3e68...aeff36c

Copy link
Contributor

@nickschot nickschot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Throws the expected error in all cases and allows null on nullable parameters.

@zacharygolba zacharygolba merged commit 090f871 into master Nov 12, 2016
@zacharygolba zacharygolba deleted the fix-nullable-params branch November 12, 2016 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants