fix: make sure dates are correctly validated & parsed #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: make sure transform-keys doesn't recurse into a Date object
Current coverage is 91.93% (diff: 100%)@@ master #639 diff @@
==========================================
Files 179 179
Lines 1982 1984 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1822 1824 +2
Misses 160 160
Partials 0 0
|
zacharygolba
suggested changes
Jan 17, 2017
| @@ -20,6 +20,7 @@ export function transformKeys<T: Object | Array<mixed>>( | |||
| return entries(source).reduce((result, [key, value]) => { | |||
| const recurse = deep | |||
| && value | |||
| && !(value instanceof Date) | |||
There was a problem hiding this comment.
Can you move this line to after the typeof value === 'object' check?
zacharygolba
approved these changes
Jan 17, 2017
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: make sure dates are correctly validated
fix: make sure transform-keys doesn't recurse into a Date object
Proposed fix for #621