fix: middleware functions added in 'beforeAction' not executing #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of middleware not being executed when added to the
beforeAction
array on aController
.The reason this bug exists is because #65 introduced many improvements where previously computed properties were moved to it's classes constructor in attempt to prevent multiple executions of a
getter
. The downside of doing this is that class properties will not be installed on theprototype
until after the constructor is called. This simply moves themiddleware
property back to a computedgetter
function which is later memoized in theRoute
class upon the application's boot so there is no perf regression.This PR also removes the parent class
Base
fromController
which is part of an ongoing refactor to no longer be usingBase
as a parent for packages within Lux. It doesn't provide any additional functionality since we can mimicsetProps
withObject.assign(this, props)
and it will be better to not dirty the prototype chain moving forward unless it's absolutely necessary.Closes #94