Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pagesix parser #97

Merged
merged 13 commits into from
Feb 7, 2017
Merged
21 changes: 21 additions & 0 deletions fixtures/pagesix.com/1482254007534.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export * from './www.reuters.com';
export * from './mashable.com';
export * from './www.chicagotribune.com';
export * from './www.vox.com';
export * from './pagesix.com';
export * from './www.thepoliticalinsider.com';
export * from './www.mentalfloss.com';
export * from './abcnews.go.com';
Expand Down
58 changes: 58 additions & 0 deletions src/extractors/custom/pagesix.com/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
export const PagesixComExtractor = {
domain: 'pagesix.com',

supportedDomains: [
'nypost.com',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also appears that nypost.com has a very similar layout, and appears to be compatible with this one, since they are in the same network of sites.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

],

title: {
selectors: [
'h1 a',
],
},

author: {
selectors: [
'.byline',
],
},

date_published: {
selectors: [
['meta[name="article:published_time"]', 'value'],
],
},

dek: {
selectors: [
['meta[name="description"]', 'value'],
],
},

lead_image_url: {
selectors: [
['meta[name="og:image"]', 'value'],
],
},

content: {
selectors: [
['#featured-image-wrapper', '.entry-content'],
'.entry-content',
],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
'#featured-image-wrapper': 'figure',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as the other PR where I'd like @adampash to verify.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I missed this. What did you want me to verify, @kev5873?

'.wp-caption-text': 'figcaption',
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [
'.modal-trigger',
],
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's how I'd re-write the content extractor:

  content: {
    selectors: [
      ['#featured-image-wrapper', '.entry-content'],
      '.entry-content',
    ],

    // Is there anything in the content you selected that needs transformed
    // before it's consumable content? E.g., unusual lazy loaded images
    transforms: {
      '#featured-image-wrapper': 'figure',
      '.wp-caption-text': 'figcaption',
    },

    // Is there anything that is in the result that shouldn't be?
    // The clean selectors will remove anything that matches from
    // the result
    clean: [
      '.modal-trigger',
    ],
  },

So, bit by bit:

    selectors: [
      ['#featured-image-wrapper', '.entry-content'],
      '.entry-content',
    ],

First, by focusing on .entry-content instead of .article-header, you don't have to clean near as much from the page (see the much smaller clean section). You can still get the lead image by doing a multi-element selector for the content — this says get the #featured-image-wrapper, then get the .entry-content, and put them together.

    transforms: {
      '#featured-image-wrapper': 'figure',
      '.wp-caption-text': 'figcaption',
    },

This transform just changes div#featured-image-wrapper to a figure, which will then work correctly — and then we can also easily transform div.wp-caption-text into a figcaption.

};
88 changes: 88 additions & 0 deletions src/extractors/custom/pagesix.com/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
import assert from 'assert';
import fs from 'fs';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

describe('PagesixComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'http://pagesix.com/2016/12/19/sofia-vergara-and-nick-loebs-embryo-drama-taking-a-detour/';
const html =
fs.readFileSync('./fixtures/pagesix.com/1482254007534.html');
result =
Mercury.parse(url, html, { fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/pagesix.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(title, 'Sofía Vergara and Nick Loeb’s embryo drama taking a detour');
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/pagesix.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Oli Coleman');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/pagesix.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2016-12-20T00:08:44.000Z');
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/pagesix.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(lead_image_url, 'https://nyppagesix.files.wordpress.com/2016/12/sofia-vergara4.jpg?quality=90&strip=all&w=1200');
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/pagesix.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent($('*').first().text(), 13);

// Update these values with the expected values from
// the article.

assert.equal(first13, 'Nick Loeb and Sofia Vergara Shutterstock / Getty Images (Composite) In the latest');
});
});
});