Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign user errors when curl conversion fails due to handled cases #66

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Assign user errors when curl conversion fails due to handled cases #66

merged 2 commits into from
Jun 22, 2023

Conversation

dhwaneetbhatt
Copy link
Contributor

@dhwaneetbhatt dhwaneetbhatt commented Jun 20, 2023 •
edited
Loading

This PR

  • Adds a new error type UserError
  • Returns all known handled error scenarios wrapped in UserError
  • Adds an error object to the object returned in callback as error
  • Moves all known error messages to a constants file

Screenshot 2023-06-21 at 16 31 36

@dhwaneetbhatt dhwaneetbhatt self-assigned this Jun 20, 2023
VShingala
VShingala reviewed Jun 20, 2023
View reviewed changes
src/lib.js Outdated Show resolved Hide resolved
src/convert.js Outdated Show resolved Hide resolved
VShingala
VShingala approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhwaneetbhatt dhwaneetbhatt merged commit b7971d8 into develop Jun 22, 2023
@dhwaneetbhatt dhwaneetbhatt deleted the feature/assign-user-errors branch June 22, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VShingala VShingala VShingala approved these changes

Assignees

@dhwaneetbhatt dhwaneetbhatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhwaneetbhatt @VShingala