Fixed an issue where certain character after $ were omitted while importing curl

[aman-v-singh]

Overview

Fix for the issue:- postmanlabs/postman-app-support#11888

The user was unable to import the string below correctly:-
curl -X GET "https://alextest.com/" -H "5f005074: [jKanrLih$!]SooCV5u)aI!pt9"
The output is coming out to be

{
  method: 'GET',
  name: 'https://alextest.com',
  url: 'https://alextest.com',
  header: [ { key: '5f005074', value: '[jKanrLih$!SooCV5u)aI!pt9' } ],
  body: {},
  description: 'Generated from a curl request: \n' +
    'curl -X GET \\"https://alextest.com\\" -H \\"5f005074: [jKanrLih$!]SooCV5u)aI!pt9\\"'
}

As you can see the character ] is missing in the header value.

RCA

When a curl string has $ char, and the next character matches /[*@#?$!_\-]/, the character after that skipped because the index was incremented seemingly unnecessarily.

Fix

Remove unnecessary index increment.

Output

The output after fix is correct and as expected.

{
  method: 'GET',
  name: 'https://alextest.com',
  url: 'https://alextest.com',
  header: [ { key: '5f005074', value: '[jKanrLih$!]SooCV5u)aI!pt9' } ],
  body: {},
  description: 'Generated from a curl request: \n' +
    'curl -X GET \\"https://alextest.com\\" -H \\"5f005074: [jKanrLih$!]SooCV5u)aI!pt9\\"'
}

[VShingala]

Let's add unit test for this fix as well.