Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Commit

Permalink
download files in silent mode
Browse files Browse the repository at this point in the history
logging to stdout very fast causes node to crash with heap out of memory
nodejs/node#3171
  • Loading branch information
harryi3t committed Oct 27, 2019
1 parent e9fd989 commit eb0b150
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions script/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ async function verifyAssets (release) {
let filesToCheck = await Promise.all(release.assets.map(async (asset) => {
githubOpts.id = asset.id
let assetDetails = await github.repos.getAsset(githubOpts)
await downloadFiles(assetDetails.meta.location, downloadDir, false, asset.name)
await downloadFiles(assetDetails.meta.location, downloadDir, true, asset.name)
return asset.name
})).catch(err => {
console.log(`${fail} Error downloading files from GitHub`, err)
Expand Down Expand Up @@ -344,7 +344,7 @@ async function verifyShasums (urls, isS3) {
let filesToCheck = []
try {
if (!isS3) {
await downloadFiles(urls, downloadDir)
await downloadFiles(urls, downloadDir, true)
filesToCheck = urls.map(url => {
let currentUrl = new URL(url)
return path.basename(currentUrl.pathname)
Expand Down

0 comments on commit eb0b150

Please sign in to comment.