Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Travis job to run 'python3.6 setup.py test' instead of tox #448

Closed
wants to merge 1 commit into from

Conversation

javabrett
Copy link
Contributor

This adds a third build to the Travis matrix, to run python3.6 setup.py test instead of tox.
This will catch installation issues of the type seen in #403.

… alternative to tox.

This will catch installation issues of the type seen in postmanlabs#403.
@sigmavirus24
Copy link
Contributor

I'd rather not. setuptools commands are janky and often end up necessitating ridiculous amounts of debugging when something goes awry. No one presently involved in this project has the time or interest to do that. Also tox should be installing httpbin via the setup.py each time. That makes me skeptical that this would catch the issue.

@javabrett
Copy link
Contributor Author

javabrett commented May 7, 2018

Also tox should be installing httpbin via the setup.py each time.

Is it currently only doing that for release builds?:

https://github.com/requests/httpbin/blob/master/tox.ini#L14
https://github.com/requests/httpbin/blob/master/tox.ini#L5

[testenv]
commands=python test_httpbin.py

[testenv:release]
...
commands =
    python setup.py sdist bdist_wheel
...

I'm not familiar with tox much, but maybe that is why it didn't catch this between releases ... was running python test_httpbin.py, should it be running python setup.py?

@sigmavirus24
Copy link
Contributor

Tox by default runs python setup.py install

@javabrett javabrett mentioned this pull request Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants