Run unittests in docker container #520
Closed
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
javabrett
suggested changes
Oct 28, 2018
There was a problem hiding this comment.
Instead of having a Compose service to run the tests, why not run them on image-build? I don't see the advantage in having a Compose service to run the tests at container start-time ... isn't this just retesting the same code repeatedly unless the image is rebuilt in the interim, and so wouldn't it be better to test at that time?
javabrett
reviewed
Oct 28, 2018
| @@ -7,10 +7,18 @@ A [Kenneth Reitz](http://kennethreitz.org/bitcoin) Project. | |||
|
|
|||
| Run locally: | |||
| ```sh | |||
| docker pull kennethreitz/httpbin | |||
There was a problem hiding this comment.
Why is this deleted? It could result in a stale/cached image.
|
Closing as it solves my problems but not necessarily useful for anyone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
I was not able to run
toxtests on mac. I assume this is fixable, but running tests in a container gives a more predictable environment.what
testservice todocker-compose.ymlthat runs the unittests.README.md