Fixed an issue where schemas under allOf keyword having additionalProperties set to false were not generating bodies correctly. #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perties set to false were not generating bodies correctly
aman-v-singh
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue reported by user: #417 (comment)
RCA
Issue was with merging schemas under
allOf, specifically havingadditionalProperties: false. Third-party library (https://github.com/mokkabonna/json-schema-merge-allof) used for this purpose was defaulting to resolving no properties in such case leaving the resolved schema body empty.Fix
We'll be using suggested option
ignoreAdditionalPropertiesastruein such cases. This makes sure that we're keeping request data from schemas underlyingallOfkeywords correctly instead of consideringadditionalPropertiesin one of schema.See more about this option here: https://github.com/mokkabonna/json-schema-merge-allof?tab=readme-ov-file#options