Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NTLM auth state when iterationCount is more than 2 #945

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

coditva
Copy link
Member

@coditva coditva commented Dec 19, 2019

This fix is kind of a hack because the architecture is not ideal.
Verified that tests fail before the fix.

@coditva coditva marked this pull request as ready for review December 19, 2019 07:20
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #945 into develop will increase coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #945      +/-   ##
==========================================
+ Coverage    90.77%   90.8%   +0.03%     
==========================================
  Files           42      42              
  Lines         2373    2381       +8     
  Branches       668     670       +2     
==========================================
+ Hits          2154    2162       +8     
  Misses         219     219
Flag Coverage Δ
#integration 80% <75%> (+0.06%) ⬆️
#legacy 58.29% <18.75%> (-0.12%) ⬇️
#unit 47.24% <0%> (-0.16%) ⬇️
Impacted Files Coverage Δ
lib/runner/extensions/item.command.js 92.85% <100%> (+0.17%) ⬆️
lib/authorizer/ntlm.js 89.87% <69.23%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7da34...87179ca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant