Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed missing buffer globals for compatibility #1035

Open
wants to merge 2 commits into
base: feature/fix-buffer
Choose a base branch
from

Conversation

appurva21
Copy link
Member

@appurva21 appurva21 commented Aug 29, 2024

Exposed the following buffer globals to provide a uniform interface on the browser and node environment:

@appurva21 appurva21 requested a review from codenirvana August 29, 2024 09:21
@appurva21 appurva21 changed the title Added missing buffer APIs to expose a uniform interface across environments Exposed missing buffer globals and APIs for compatibility Aug 29, 2024
@appurva21 appurva21 force-pushed the feature/add-missing-buffer-apis branch from f2559b2 to 4632eaf Compare August 29, 2024 13:18
@appurva21 appurva21 changed the title Exposed missing buffer globals and APIs for compatibility Exposed missing buffer globals for compatibility Aug 29, 2024
@appurva21 appurva21 force-pushed the feature/add-missing-buffer-apis branch from 4632eaf to 394ba44 Compare August 29, 2024 13:44
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (3e044f0) to head (e5bcec7).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/fix-buffer    #1035   +/-   ##
===================================================
  Coverage               52.77%   52.77%           
===================================================
  Files                      12       12           
  Lines                     612      612           
  Branches                  146      146           
===================================================
  Hits                      323      323           
  Misses                    249      249           
  Partials                   40       40           
Flag Coverage Δ
unit 52.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appurva21 appurva21 force-pushed the feature/add-missing-buffer-apis branch from 394ba44 to c227895 Compare September 23, 2024 17:05
@appurva21 appurva21 force-pushed the feature/add-missing-buffer-apis branch from c227895 to 6ac7540 Compare September 24, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant