Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blob to allowed list of globals #683

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Add Blob to allowed list of globals #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56a2b79
Add `Blob` to allowed list of globals
appurva21 Sep 24, 2024
b469203
Update CHANGELOG.yaml
appurva21 Sep 25, 2024
ea4646a
Update allowed-globals.js
appurva21 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ unreleased:
- >-
GH-676 Updated allowed globals list to include:
URL, Encoding, Cryptographic, and Stream APIs
- GH-683 Updated allowed globals list to include `Blob`
chores:
- GH-677 Updated ESLint rules
- GH-677 Updated dependencies
Expand Down
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ These are the list of globals available to scripts in the scope
]
```

### File:
```json
[
"Blob"
]
```

### Cryptography:
```json
[
Expand Down
4 changes: 4 additions & 0 deletions lib/allowed-globals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ module.exports = [
'TextDecoder', 'TextDecoderStream',
'TextEncoder', 'TextEncoderStream',

// File
// TODO: Add `File` class once support for node < v20 is dropped
'Blob',

// Cryptography
'Crypto', 'CryptoKey',
'crypto', 'SubtleCrypto',
Expand Down
25 changes: 13 additions & 12 deletions test/unit/scope-globals.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,19 @@ describe('scope module globals', function () {
scope.exec(`
var availableGlobals = Object.getOwnPropertyNames(this).sort();
expect(availableGlobals).eql(['Array', 'ArrayBuffer', 'Atomics', 'atob', 'BigInt', 'BigInt64Array',
'BigUint64Array', 'Boolean', 'ByteLengthQueuingStrategy', 'CompressionStream', 'CountQueuingStrategy',
'btoa', 'Crypto', 'CryptoKey', 'crypto', 'DataView', 'Date', 'DecompressionStream', 'decodeURI',
'decodeURIComponent', 'encodeURI', 'encodeURIComponent', 'Error', 'escape', 'EvalError', 'Float32Array',
'Float64Array', 'Function', 'Infinity', 'Int8Array', 'Int16Array', 'Int32Array', 'isFinite', 'isNaN',
'JSON','Map', 'Math', 'NaN', 'Number', 'Object', 'parseFloat', 'parseInt', 'Proxy', 'Promise',
'RangeError', 'ReadableByteStreamController', 'ReadableStream', 'ReadableStreamBYOBReader',
'ReadableStreamBYOBRequest', 'ReadableStreamDefaultController', 'ReadableStreamDefaultReader',
'ReferenceError', 'Reflect', 'RegExp', 'Set', 'SharedArrayBuffer', 'String', 'SubtleCrypto', 'Symbol',
'SyntaxError', 'TextDecoder', 'TextDecoderStream', 'TextEncoder', 'TextEncoderStream',
'TransformStream', 'TransformStreamDefaultController', 'TypeError', 'Uint8Array', 'Uint8ClampedArray',
'Uint16Array', 'Uint32Array', 'undefined', 'unescape', 'URIError', 'URL', 'URLSearchParams', 'WeakMap',
'WeakSet', 'WritableStream', 'WritableStreamDefaultController', 'WritableStreamDefaultWriter',
'BigUint64Array', 'Blob', 'Boolean', 'ByteLengthQueuingStrategy', 'CompressionStream',
'CountQueuingStrategy', 'btoa', 'Crypto', 'CryptoKey', 'crypto', 'DataView', 'Date',
'DecompressionStream', 'decodeURI', 'decodeURIComponent', 'encodeURI', 'encodeURIComponent',
'Error', 'escape', 'EvalError', 'Float32Array', 'Float64Array', 'Function', 'Infinity', 'Int8Array',
'Int16Array', 'Int32Array', 'isFinite', 'isNaN', 'JSON','Map', 'Math', 'NaN', 'Number', 'Object',
'parseFloat', 'parseInt', 'Proxy', 'Promise', 'RangeError', 'ReadableByteStreamController',
'ReadableStream', 'ReadableStreamBYOBReader', 'ReadableStreamBYOBRequest',
'ReadableStreamDefaultController', 'ReadableStreamDefaultReader', 'ReferenceError', 'Reflect', 'RegExp',
'Set', 'SharedArrayBuffer', 'String', 'SubtleCrypto', 'Symbol', 'SyntaxError', 'TextDecoder',
'TextDecoderStream', 'TextEncoder', 'TextEncoderStream', 'TransformStream',
'TransformStreamDefaultController', 'TypeError', 'Uint8Array', 'Uint8ClampedArray', 'Uint16Array',
'Uint32Array', 'undefined', 'unescape', 'URIError', 'URL', 'URLSearchParams', 'WeakMap', 'WeakSet',
'WritableStream', 'WritableStreamDefaultController', 'WritableStreamDefaultWriter',
'expect' // special for test
].sort())
`, done);
Expand Down
Loading