Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce configurable percentiles for wavefront sink #222

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

blt
Copy link
Collaborator

@blt blt commented Mar 5, 2017

This commit makes it possible for the end-user to specify what
percentiles will be shipped out in the wavefront sink. The config
for doing so is... goofy. This problem is discussed in #221.

This commit resolves #218.

Signed-off-by: Brian L. Troutwine blt@postmates.com

This commit makes it possible for the end-user to specify what
percentiles will be shipped out in the wavefront sink. The config
for doing so is... goofy. This problem is discussed in #221.

This commit resolves #218.

Signed-off-by: Brian L. Troutwine <blt@postmates.com>
@blt blt requested review from gliush and tsantero March 5, 2017 19:13
@blt
Copy link
Collaborator Author

blt commented Mar 5, 2017

/cc @bitglue

@codecov
Copy link

codecov bot commented Mar 5, 2017

Codecov Report

Merging #222 into master will increase coverage by 0.48%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   96.55%   97.03%   +0.48%     
==========================================
  Files          22       22              
  Lines        2841     2967     +126     
==========================================
+ Hits         2743     2879     +136     
+ Misses         98       88      -10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301d104...d784c64. Read the comment docs.

@gliush
Copy link
Contributor

gliush commented Mar 5, 2017

LGTM, though, I don't like that we have the same percentiles initialisation code (though, I realise that right now we can't fix it).

@blt blt merged commit 9dbf4c6 into master Mar 6, 2017
@blt blt deleted the configurable_percentiles branch March 6, 2017 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make WF percentiles configurable
2 participants