cernan.sinks.prometheus.aggregation.reportable as SET, not SUM #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Prometheus sink we have PROMETHEUS_AGGR_REPORTABLE as a store, rather than a summation. We previously reported this out as a SUM from the internal source. This commit corrects that mistake. Signed-off-by: Brian L. Troutwine <blt@postmates.com>
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 91.82% 91.87% +0.04%
==========================================
Files 31 31
Lines 4171 4171
==========================================
+ Hits 3830 3832 +2
+ Misses 341 339 -2 |
blt
pushed a commit
that referenced
this pull request
May 22, 2018
This release contains a memory-leak fix for our kafka dependency as well as a change to prometheus internal telemetry. The bulk of the diff is in automatic upgrades to our crates. * 12520e9 :: cernan.sinks.prometheus.aggregation.reportable as SET, not SUM (#435) * ed4339e :: Upgrade rdkafka to 0.11.4 (rustrdkafka to 0.16.0) (#436) Signed-off-by: Brian L. Troutwine <blt@postmates.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Prometheus sink we have PROMETHEUS_AGGR_REPORTABLE as a
store, rather than a summation. We previously reported this out
as a SUM from the internal source. This commit corrects that
mistake.
Signed-off-by: Brian L. Troutwine blt@postmates.com