fix: scanner: make state_new() static
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this is what causing issues for multiple projects attempting to use this grammar: - neurocyte/zat#1 - zed-industries/zed#7543 (comment) Don't know why it wasn't static in the first place (in the original Haskell grammar), but I looked at what other grammars do and none export any functions other than those used by Tree-sitter.
|
This seems to have broken the use of this parser on Neovim in Windows: https://github.com/nvim-treesitter/nvim-treesitter/actions/runs/8015659451/job/21898292793?pr=6179 (Unclear how exactly; I don't have access to a Windows box.) |
|
No; we don't use these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this is what's causing issues for multiple projects attempting to use this grammar:
PureScript and Haskell conflict neurocyte/zat#1
Linux: Disable PureScript grammar to avoid linking error zed-industries/zed#7543 (comment)
Don't know why it wasn't static in the first place (in the original Haskell grammar), but I looked at what other grammars do and none export any functions other than those used by Tree-sitter.