Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zach/sort vars formatting #26

Closed
wants to merge 2 commits into from
Closed

Conversation

ZachJHansen
Copy link
Collaborator

Implementing an order on variables (alphabetical w.r.t. names) so quantifications are printed the same way even if they were assembled from an unordered set of variables (as is often the case in tau*)

@teiesti
Copy link
Collaborator

teiesti commented Nov 9, 2023

I strongly object this change as you resolve an issue in formatting that really should be resolved in the syntax tree itself. I believe that formatting should create a string representation that is as close to the syntax tree as possible. So, if you want to have the variables sorted, you really should make sure that they are sorted in the syntax tree.

@ZachJHansen ZachJHansen deleted the zach/sort_vars_formatting branch December 19, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants