Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect peer computation for > 32 threads #105

Closed
BenKaufmann opened this issue Oct 10, 2024 · 0 comments
Closed

Incorrect peer computation for > 32 threads #105

BenKaufmann opened this issue Oct 10, 2024 · 0 comments
Assignees
@BenKaufmann
Labels
bug

Comments

@BenKaufmann
Copy link
Contributor

When clasp is run with more than 32 threads, peer computation for nogood exchange is incorrect and results in missing communication links (33-63 threads) or no links at all (64 threads).

Problem:

  • Distributor::initSet() is limited to 32 threads but should be able to handle max_threads, which is currently 64.

Tasks:

  • Adjust Distributor::initSet() and ParallelSolveOptions::initPeerMask() to 64 threads.
  • Add missing unit tests
@BenKaufmann BenKaufmann added bug in progress Issue is currently being worked on labels Oct 10, 2024
@BenKaufmann BenKaufmann self-assigned this Oct 10, 2024
BenKaufmann added a commit that referenced this issue Oct 11, 2024
@BenKaufmann
Issue #105: Fix peer computation for > 32 threads.
519345a 
* Distributor::initSet() incorrectly returned an uint32 thereby limiting
  peer groups to 32 threads.

* Simplify ParallelSolveOptions::initPeerMask() and add basic tests.
BenKaufmann added a commit that referenced this issue Oct 11, 2024
@BenKaufmann
Issue #105: Fix peer computation for > 32 threads.
c5ef7f2 
* Distributor::initSet() incorrectly returned an uint32 thereby limiting
  peer groups to 32 threads.

* Simplify ParallelSolveOptions::initPeerMask() and add basic tests.
@BenKaufmann BenKaufmann removed the in progress Issue is currently being worked on label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenKaufmann BenKaufmann

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenKaufmann