Add support for Thoas (a yet another JSON library) #126
Conversation
|
The failures are due to git clone/TCP connection timeouts, GitHub is having a rough day it seems. I run into the same issue locally. |
|
@ericmj is this something you'd be interested in accepting or should Team RabbitMQ use our own fork? Thank you 🙏 |
|
I want to include this but it's blocked by CI failing due to the no longer supported I don't really have the time or knowledge of this library to fully maintain it. I can only merge PRs that I confirm to work by CI passing and make new releases until @potatosalad comes back or someone else is willing to take over and do proper maintainership. If you want this merged I unfortunately must ask you or another contributor to first fix CI. We may be able to change the libdecaf dependency back to https://github.com/potatosalad/erlang-libdecaf but it needs to be updated or forked to use a supported git protocol. |
|
I can take a look at this soon. |
|
@potatosalad thank you. If you'd like someone to help out with this library, I'd be happy to. I am not a crypto expert but I'm sure there are issues that either won't require much knowledge (like this one) or, given enough motivation, new maintainers can meaningfully help with. |
|
It's been more than two weeks, any updates on this? It's a pretty low risk change :) |
|
It's been close to a month now, @potatosalad should I assume that JOSE maintainers are not interested in this PR and RabbitMQ should run a fork of JOSE from now on? |
michaelklishin
force-pushed
the
mk-thoas-support
branch
from
5d0e927
to
d63c1c5
Compare
|
Rebased on top of |
|
We can merge this if you also fix CI. That can be done in a separate PR or in this PR. Feel free to fork libdecaf if you need to. |
|
@ericmj I got libdecaf 2.1.0 released yesterday which should fix the CI issues there, currently working on getting libsodium functional again on modern OTP so that this project's CI can work again. |
|
@potatosalad Thank you very much. Greatly appreciated! |
We had to fork it for Thoas support but it's been merged a long time ago potatosalad/erlang-jose#126
We had to fork it for Thoas support but it's been merged a long time ago potatosalad/erlang-jose#126
We had to fork it for Thoas support but it's been merged a long time ago potatosalad/erlang-jose#126 (cherry picked from commit 65cbe5d)
@ericmj sorry to ping you directly but this turned out to be an unexpected blocker for Thoas adoption in RabbitMQ :) If you agree to accept this PR, we'd appreciate a new tag we can depend on.