Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parentheses to remove the ambiguity on Elixir 1.4 #26

Merged
merged 1 commit into from
Dec 11, 2016
Merged

add parentheses to remove the ambiguity on Elixir 1.4 #26

merged 1 commit into from
Dec 11, 2016

Conversation

alexandrubagu
Copy link

When using Elixir 1.4 new warnings are raised:

warning: variable "erlc_options" does not exist and is being expanded to "erlc_options()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:8

warning: variable "deps" does not exist and is being expanded to "deps()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:11

warning: variable "description" does not exist and is being expanded to "description()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:19

warning: variable "package" does not exist and is being expanded to "package()", please use parentheses to remove the ambiguity or change the variable name
  /home/alexandrubagu/devel/antidote/deps/jose/mix.exs:20

@alexandrubagu alexandrubagu changed the title add parentheses to remove the ambiguity add parentheses to remove the ambiguity on Elixir 1.4 Dec 9, 2016
@potatosalad
Copy link
Owner

@alexandrubagu Awesome, thanks!

@potatosalad potatosalad merged commit fcd8afd into potatosalad:master Dec 11, 2016
@alexandrubagu
Copy link
Author

Can you create a new tag with this ? There are libraries which still use 1.8 tag and are warnings when you compile

potatosalad added a commit that referenced this pull request Feb 2, 2017
* Fixes
  * Parentheses to remove ambiguity on Elixir 1.4 #26, thanks @alexandrubagu
@potatosalad
Copy link
Owner

@alexandrubagu Just published version 1.8.1 with your changes included. Thanks!

@alexandrubagu
Copy link
Author

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants