Fix cross platform issues of EC signatures #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* EC Signatures should be 64, 96 or 132 octet sequences according to https://tools.ietf.org/html/rfc7518#section-3.4 * Previous padding implementation can generate signatures that are shorter than what is stated in the RFC and other platform (non-erlang VM) librarys may fail to verify the signature
epretha
approved these changes
Mar 7, 2017
|
Thanks! |
potatosalad
added a commit
that referenced
this pull request
Mar 15, 2017
* Enhancements * Add support for decoding firebase certificate public keys (thanks to @noizu, see #30) * Fixes * Fix cross-platform issues with EC signatures (specifically S and R sizes, thanks to @alexandrejbr, see #32) * Typo in documentation for `JOSE.encode/1` (thanks to @DaveLampton, see #31) * Tests * Tested against OTP 19.3, Elixir 1.4.x, and Poison 3.x
|
This has been included in jose 1.8.2, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EC Signatures should be 64, 96 or 132 octet sequences according to
https://tools.ietf.org/html/rfc7518#section-3.4
Previous padding implementation can generate signatures that are
shorter than what is stated in the RFC and other platform
(non-erlang VM) librarys may fail to verify the signature