Install packages after downloading. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds another loop to install all packages after downloading. It is similar to the [prebuild](https://github.com/technosophos/gpm-prebuild) plugin. It doesn't run in parallel. The main difference is that it won't run `go install $package/...`. This is a somewhat confusing on prebuild, and fails with some repos, since `go get` is made to work with packages, not repos. A possible solution would be to add the wildcard to the dependency itself, in the Gofile. Regardless, this is a possible start that should at least work safely for the majority of use cases. Original discussion [here](#58)
|
Perfect, I'll probably make a new release soon including this changes. :) Thanks again! ❤️ |
pote
pushed a commit
that referenced
this pull request
Jan 11, 2015
Install packages after downloading.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds another loop to install all packages after downloading. It is
similar to the prebuild
plugin. It doesn't run in parallel.
The main difference is that it won't run
go install $package/.... This is asomewhat confusing on prebuild, and fails with some repos, since
go getis made to work with packages, not repos.A possible solution would be to add the wildcard to the dependency itself, in
the Gofile.
Regardless, this is a possible start that should at least work safely for the
majority of use cases.
Original discussion here