Adding support for PLL reference clock #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bladeRF_Settings.cpp
Outdated
| ranges.emplace_back(overallRange.minimum()/1.0, overallRange.maximum()/4.0, overallRange.maximum()/16.0); | ||
| ranges.emplace_back(overallRange.maximum()/4.0, overallRange.maximum()/2.0, overallRange.maximum()/8.0); | ||
| ranges.emplace_back(overallRange.maximum()/2.0, overallRange.maximum()/1.0, overallRange.maximum()/4.0); | ||
| return ranges; |
There was a problem hiding this comment.
I dont know why these fake ranges ended up here in the first place. It might have been for a GUI to infer a drop down over sliders. I have half a mind to remove it from getSampleRateRange.
In this case, just return {range};
There was a problem hiding this comment.
I'm also not sure why they're there. Just trying to fit in with the style of similar functions. I'll update that.
|
Seems good, and adds functionality. Might revisit after merging any API additions to SoapySDR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #36
This is the version with support only for the PLL and nothing related to clock buffer selection.