Set label when PlutoSDR is USB-connected

[argilo]

When a PlutoSDR device is connected by USB, SoapyPlutoSDR calculates a label but fails to assign it to the options object. This results in PlutoSDR devices being displayed as "Unknown" in Gqrx.

I also noticed that the label is generated using a fixed-length buffer and sprintf, which is dangerous. I've replaced this with std::ostringstream.

Finally, I changed the device name to PlutoSDR instead of plutosdr to match how other devices are displayed.

Before:

% SoapySDRUtil --find
######################################################
##     Soapy SDR -- the SDR abstraction library     ##
######################################################

Found device 0
  device = plutosdr
  driver = plutosdr
  uri = usb:20.2.5

After:

% SoapySDRUtil --find
######################################################
##     Soapy SDR -- the SDR abstraction library     ##
######################################################

Found device 0
  device = PlutoSDR
  driver = plutosdr
  label = PlutoSDR #0 usb:20.2.5
  uri = usb:20.2.5

[zuckschwerdt]

I had a look through other modules, and the commonality seems to be "label" and "serial". The key "device" is used in HackRF, but specifically to identify the hardware type.
A descriptive "label" seems good practice. But "device" (if we can claim to known anything about the hardware) should likely be just "Pluto" or "ADALM Pluto", right?

[argilo]

"ADALM Pluto" sounds good to me. I'll update it to that.

[argilo]

Done. I also updated the PR description with the new output.

[zuckschwerdt]

I like it. Let's give this a few days for other users to maybe offer feedback.

[argilo]

Actually, it looks like the official name is "ADALM-PLUTO", with "PlutoSDR" being the short version: https://wiki.analog.com/university/tools/pluto

The iio_context_info_get_description function returns this:

0456:b673 (Analog Devices Inc. PlutoSDR (ADALM-PLUTO)), serial=1044735411960001110030006e061e4d34

So it would seem that either "PlutoSDR" or "ADALM-PLUTO" would be best. Which of those do you prefer?

[zuckschwerdt]

Oops, sorry. That's confusing. I guess "PlutoSDR" would be nicer than "ADALM-PLUTO", if those are the options of "official" names for the hardware.

[argilo]

Agreed, I like "PlutoSDR" better as well. I'll switch it back.

[argilo]

Let's give this a few days for other users to maybe offer feedback.

10 days have passed with no other feedback. Can this be merged now?

[argilo]

Thanks!

[zuckschwerdt]

No need. It's not my project, just lots of community effort!