Skip to content

Commit

Permalink
Fix reproducibility of prepared provider packages (fix flit frontend) (
Browse files Browse the repository at this point in the history
…apache#43683)

After some checks it turned out that reproducibility of produced
packages depends not only on the build backend configured for the
project but also on the build front-end used - because frontend is
the one to modify meta-data in prepared packages - including the build
tool used, it's version and metadata version supported by the front-end.

That's why in order to maintain reproducibility for anyone who builds
the packages, we have to pin not only the build backend in
pyproject.toml (flit-core) but also build fronted used (flit).

Since package preparation is done with breeze, we can do it by
pinning flit (and just in case also flit-core) so that anyone who
builds specific version of the package will use exactly the same flit
as the person who built the original packages.

This way we will avoid reproducibility problems experienced with 1.5.0
release of FAB.

(cherry picked from commit 18ea01c)
  • Loading branch information
potiuk committed Nov 5, 2024
1 parent 58c18ff commit 57d397d
Show file tree
Hide file tree
Showing 21 changed files with 73 additions and 50 deletions.
1 change: 0 additions & 1 deletion dev/README_RELEASE_PROVIDER_PACKAGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ export AIRFLOW_REPO_ROOT=$(pwd -P)
rm -rf ${AIRFLOW_REPO_ROOT}/dist/*
```


* Release candidate packages:

```shell script
Expand Down
2 changes: 1 addition & 1 deletion dev/breeze/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ PLEASE DO NOT MODIFY THE HASH BELOW! IT IS AUTOMATICALLY UPDATED BY PRE-COMMIT.

---------------------------------------------------------------------------------------------------------

Package config hash: f8e8729f4236f050d4412cbbc9d53fdd4e6ddad65ce5fafd3c5b6fcdacbea5431eea760b961534a63fd5733b072b38e8167b5b0c12ee48b31c3257306ef11940
Package config hash: d1d07397099e14c5fc5f0b0e13a87ac8e112bf66755f77cee62b29151cd18c2f2d35932906db6b3885af652defddce696ef9b2df58e21bd3a7749bca82baf910

---------------------------------------------------------------------------------------------------------
28 changes: 14 additions & 14 deletions dev/breeze/doc/images/output_build-docs.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_build-docs.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ac6594538890f8fba65c916aa8672aa1
91166ce4114ea9c162c139d2aff15886
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_prod-image.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_prod-image.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
55030fe0d7718eb668fa1a37128647b0
d91bcc76b14f186e749efe2c6aaa8682
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_prod-image_build.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
88290b22adcd4e5cc9da29aaa8467992
c243f4de16bc858f6202d88922f00109
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dev/breeze/doc/images/output_setup.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d4a4f1b405f912fa234ff4116068290a
08c78d9dddd037a2ade6b751c5a22ff9
Loading

0 comments on commit 57d397d

Please sign in to comment.