Strip repeated slashes from URL path #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will replace the default behaviour of redirecting to serving the resource directly. For example for request GET /path//to/file the previous behavior was to send 301 Moved Permanently with Location: /path/to/file header. The new behavior is to treat the path as /path/to/file and serve the file immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace the default behavior of redirecting to serving the resource directly.
For example for request
GET /path//to/filethe previous behavior was to respond with301 Moved PermanentlywithLocation: /path/to/fileheader.The new behavior is to treat the path as
/path/to/fileand serve the file immediately.There are some tools that create URLs by concatenating strings and end up having repeated slashes in the resulting URL. Some of these tools are also not following redirects and end up with an incorrect result. It is by far easier to have the server to support this arguably incorrect behavior than it is to fix these tools.