Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: get pull request info with pagination #10

Merged
merged 1 commit into from
May 4, 2018

Conversation

zhuangqh
Copy link
Member

Signed-off-by: zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

fix bug: Pouchrobot retrieve pull request info missing pagination, just retrieve the first page with default 30 items perpage.

Ⅱ. Does this pull request fix one issue?
fixes: #9

Ⅲ. Describe how you did it

Requests that return multiple items will be paginated to 30 items by default.
https://developer.github.com/v3/#pagination

Retrieve issueSearchResult page by page.

@allencloud
Copy link
Member

sorry for the delay, LGTM, and I will test for project pouch.

@allencloud allencloud merged commit d7db38e into pouchcontainer:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] every weekly report always report 30 pull requests, it is not true
2 participants