Fix "req.query.hasOwnProperty is not a function" error #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use ��`express-pouchdb` through `hoodie` and got this error. I don't exactly understand why is it happening, but I found mentions of this bug in some versions of express. I hope you'll merge it, the changes looks harmless. Thank you :)
|
This is a change in node v6. See nodejs/node#6289 |
|
I’ve restarted the failed builds (timeout error), one made it, one still fails, but it looks like we can ignore it? https://travis-ci.org/pouchdb/express-pouchdb/jobs/148555328#L5563 This is kinda a blocker for Hoodie right now, would be great if we could get this merged and a patch version released. Please let me know if there is anything I can help with |
|
I started a PR, and I released a fork with it merged on npm if you want to give it a try: https://www.npmjs.com/package/@gr2m/express-pouchdb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use ��
express-pouchdbthroughhoodieand got this error. I don't exactly understand why is it happening, but I found mentions of this bug in some versions of express. I hope you'll merge it, the changes looks harmless. Thank you :)