Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Only treat express-pouchdb running in fullCouchDB mode as a couchdb instance. #7015

Closed
wants to merge 1 commit into from

Conversation

loic
Copy link
Contributor

@loic loic commented Jan 16, 2018

@marten-de-vries
Copy link
Member

👍 when green, although this will probably require a pouchdb-server release first, right?

@loic
Copy link
Contributor Author

loic commented Jan 17, 2018

We'd lose the ability to test against express-pouchdb until a new version is released. I think we don't need to rush merging this one, pouchdb-server has an interim fix in its own test suite.

Issuing a new release of pouchdb-server with all plugins published from the monorepo is going to take some time IMO (i.e. we still need to come up with a strategy re versioning, etc.).

@marten-de-vries marten-de-vries changed the title Only treat express-pouchdb running in fullCouchDB mode as a couchdb instance. WIP - Only treat express-pouchdb running in fullCouchDB mode as a couchdb instance. Jan 17, 2018
@marten-de-vries
Copy link
Member

Ok, that sounds fine. I updated the title to prevent accidental merges in the meantime.

@marten-de-vries
Copy link
Member

I think this is no longer blocked now?

@loic
Copy link
Contributor Author

loic commented Feb 3, 2018

I think so, we just need to change the express-pouchdb server version in package.json.

@daleharvey
Copy link
Member

Closing, happy to merge this when its ready + updated pouchdb-server

@daleharvey daleharvey closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants