Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpunit/php-timer: ^7.0 support #179

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

sidz
Copy link
Collaborator

@sidz sidz commented May 19, 2024

This PR brings phpunit/php-timer: ^7.0 support

@sidz sidz requested review from exussum12 and kubawerlos May 19, 2024 12:13
Copy link
Collaborator

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the changelog it seems only the supported PHP version changed, so everything should be good.

However, none of the CI jobs is actually using version 7, as PHPUnit's constraint ^9.6 prevents using it. But we can solve this (by allowing the latest PHPUnit) separately.

@sidz sidz merged commit 3c3d4d1 into master May 20, 2024
21 checks passed
@sidz sidz deleted the add-php-unit-timer-7-support branch May 20, 2024 18:31
@sidz
Copy link
Collaborator Author

sidz commented May 20, 2024

thank you @kubawerlos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants