Feature/Implement menu bar #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borut-t
approved these changes
Nov 24, 2023
Comment on lines
+53
to
+54
| guard let windows = NSWindow.windowNumbers(), | ||
| windows.count <= 3 else { return } |
There was a problem hiding this comment.
What are windows 1 and 2?
There was a problem hiding this comment.
To be honest I'm not really sure which windows are they, didn't debug it further, just found the solution online...
However, whenever the app is minimized there are 3 windows, and 4 if the main app is not minimized.
There was a problem hiding this comment.
Interesting. But it works.
yllfejziu
force-pushed
the
feature/implement-menu-bar
branch
3 times, most recently
from
d90af89 to
9404132
Compare
yllfejziu
force-pushed
the
feature/implement-menu-bar
branch
from
9404132 to
af94af4
Compare
EgzonArifi
approved these changes
Nov 28, 2023
| } | ||
| } | ||
|
|
||
| #Preview { |
There was a problem hiding this comment.
Let's remove this since the github workflow is a version behind so it will fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #200.